Add support for Gradle assignment operator #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
builds failing due to unrelated commit |
hick209
approved these changes
Jun 11, 2024
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Yeah, I was actually the one that broke the tests and I have an internal diff that should fix that, don't worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411.
Gradle added support for a Kotlin assignment operator to simplify property assignment.
This is done via a compiler plugin and this import:
import org.gradle.kotlin.dsl.assign- which ktfmt detects as unused and removes.This PR adds an
assignoperator to the operators incom.facebook.ktfmt.format.RedundantImportDetectorand a corresponding test to ensure the import remains.